Potential fix for code scanning alert no. 4: Double escaping or unescaping#10
Merged
aunghtetnay merged 1 commit intomainfrom Oct 8, 2025
Merged
Potential fix for code scanning alert no. 4: Double escaping or unescaping#10aunghtetnay merged 1 commit intomainfrom
aunghtetnay merged 1 commit intomainfrom
Conversation
…aping Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/patchwork-hub/patchwork-web-app/security/code-scanning/4
To fix the problem, we need to ensure that the unescaping (decoding) of the HTML entities in
cleanTextis performed in the correct order: do not decode the escape character (&) before decoding the other entities. Instead, decode all other entities first, and only decode&last.Specifically, in the
cleanTextfunction, move the.replace(/&/gi, "&")line so it comes after all other.replace()calls that decode entity references for<,>,",', andnbsp. This ensures that character references like&lt;are not mistakenly decoded as<.All the changes are within the code shown, specifically in the
cleanTextmethod insrc/utils/helper/socialLink.ts(lines 50–61). No new methods, imports, or external libraries are required; only the order of replacement operations insidecleanTextneeds to be changed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.